From e8f0ec1f36de72e7be78705b414ad3e07c937b68 Mon Sep 17 00:00:00 2001
From: Fedor Katurov <gotham48@gmail.com>
Date: Sat, 8 Jan 2022 18:37:16 +0700
Subject: [PATCH] using formik on profile settings

---
 .../profile/ProfileSettings/index.tsx         | 94 ++++++-------------
 src/hooks/profile/usePatchProfile.ts          | 17 ++--
 src/hooks/profile/useProfileForm.ts           | 62 ++++++++++++
 src/redux/auth/types.ts                       |  4 +-
 src/utils/providers/ProfileProvider.tsx       |  4 +-
 5 files changed, 106 insertions(+), 75 deletions(-)
 create mode 100644 src/hooks/profile/useProfileForm.ts

diff --git a/src/components/profile/ProfileSettings/index.tsx b/src/components/profile/ProfileSettings/index.tsx
index 4f54e3bb..8ca11c68 100644
--- a/src/components/profile/ProfileSettings/index.tsx
+++ b/src/components/profile/ProfileSettings/index.tsx
@@ -1,4 +1,4 @@
-import React, { FC, useCallback, useEffect, useState } from 'react';
+import React, { FC } from 'react';
 import styles from './styles.module.scss';
 import { Textarea } from '~/components/input/Textarea';
 import { Button } from '~/components/input/Button';
@@ -10,62 +10,22 @@ import { ProfileAccounts } from '~/components/profile/ProfileAccounts';
 import classNames from 'classnames';
 import { useUser } from '~/hooks/user/userUser';
 import { useProfileContext } from '~/utils/providers/ProfileProvider';
-import { showErrorToast } from '~/utils/errors/showToast';
-import { getValidationErrors } from '~/utils/errors/getValidationErrors';
-import { showToastSuccess } from '~/utils/toast';
-import { getRandomPhrase } from '~/constants/phrases';
+import { useProfileForm } from '~/hooks/profile/useProfileForm';
+import { has } from 'ramda';
+
+const getError = (error?: string) => (error && has(error, ERROR_LITERAL) ? error : undefined);
 
 const ProfileSettings: FC = () => {
-  const [errors, setErrors] = useState<Record<string, any>>({});
   const user = useUser();
   const { updateProfile } = useProfileContext();
 
-  const [password, setPassword] = useState('');
-  const [new_password, setNewPassword] = useState('');
-
-  const [data, setData] = useState(user);
-
-  const setDescription = useCallback(description => setData({ ...data, description }), [
-    data,
-    setData,
-  ]);
-
-  const setEmail = useCallback(email => setData({ ...data, email }), [data, setData]);
-  const setUsername = useCallback(username => setData({ ...data, username }), [data, setData]);
-  const setFullname = useCallback(fullname => setData({ ...data, fullname }), [data, setData]);
-
-  const onSubmit = useCallback(
-    async event => {
-      try {
-        event.preventDefault();
-
-        const fields = {
-          ...data,
-          password: password.length > 0 && password ? password : undefined,
-          new_password: new_password.length > 0 && new_password ? new_password : undefined,
-        };
-
-        await updateProfile(fields);
-
-        showToastSuccess(getRandomPhrase('SUCCESS'));
-      } catch (error) {
-        showErrorToast(error);
-
-        const validationErrors = getValidationErrors(error);
-        if (validationErrors) {
-          setErrors(validationErrors);
-        }
-      }
-    },
-    [data, password, new_password, updateProfile]
+  const { handleSubmit, values, errors, handleChange } = useProfileForm(
+    { ...user, password: '', newPassword: '' },
+    updateProfile
   );
 
-  useEffect(() => {
-    setErrors({});
-  }, [password, new_password, data]);
-
   return (
-    <form className={styles.wrap} onSubmit={onSubmit}>
+    <form className={styles.wrap} onSubmit={handleSubmit}>
       <Group>
         <Group className={styles.pad}>
           <div className={styles.pad__title}>
@@ -73,13 +33,17 @@ const ProfileSettings: FC = () => {
           </div>
 
           <InputText
-            value={data.fullname}
-            handler={setFullname}
+            value={values.fullname}
+            handler={handleChange('fullname')}
             title="Полное имя"
-            error={errors.fullname && ERROR_LITERAL[errors.fullname]}
+            error={getError(errors.fullname)}
           />
 
-          <Textarea value={data.description} handler={setDescription} title="Описание" />
+          <Textarea
+            value={values.description}
+            handler={handleChange('description')}
+            title="Описание"
+          />
 
           <div className={styles.small}>
             Описание будет видно на странице профиля. Здесь работают те же правила оформления, что и
@@ -95,33 +59,33 @@ const ProfileSettings: FC = () => {
           </div>
 
           <InputText
-            value={data.username}
-            handler={setUsername}
+            value={values.username}
+            handler={handleChange('username')}
             title="Логин"
-            error={errors.username && ERROR_LITERAL[errors.username]}
+            error={getError(errors.username)}
           />
 
           <InputText
-            value={data.email}
-            handler={setEmail}
+            value={values.email}
+            handler={handleChange('email')}
             title="E-mail"
-            error={errors.email && ERROR_LITERAL[errors.email]}
+            error={getError(errors.email)}
           />
 
           <InputText
-            value={new_password}
-            handler={setNewPassword}
+            value={values.newPassword}
+            handler={handleChange('newPassword')}
             title="Новый пароль"
             type="password"
-            error={errors.new_password && ERROR_LITERAL[errors.new_password]}
+            error={getError(errors.newPassword)}
           />
 
           <InputText
-            value={password}
-            handler={setPassword}
+            value={values.password}
+            handler={handleChange('password')}
             title="Старый пароль"
             type="password"
-            error={errors.password && ERROR_LITERAL[errors.password]}
+            error={getError(errors.password)}
           />
 
           <div className={styles.small}>
diff --git a/src/hooks/profile/usePatchProfile.ts b/src/hooks/profile/usePatchProfile.ts
index 2c99c6ef..e7b24692 100644
--- a/src/hooks/profile/usePatchProfile.ts
+++ b/src/hooks/profile/usePatchProfile.ts
@@ -2,17 +2,20 @@ import { useUploader } from '~/hooks/data/useUploader';
 import { UploadSubject, UploadTarget } from '~/constants/uploads';
 import { useCallback } from 'react';
 import { showErrorToast } from '~/utils/errors/showToast';
-import { IUser } from '~/redux/auth/types';
+import { ApiUpdateUserRequest, IUser } from '~/redux/auth/types';
 import { apiUpdateUser } from '~/redux/auth/api';
 
 export const usePatchProfile = (updateUserData: (user: Partial<IUser>) => void) => {
   const { uploadFile } = useUploader(UploadSubject.Avatar, UploadTarget.Profiles);
 
-  const updateProfile = useCallback(async (user: Partial<IUser>) => {
-    const result = await apiUpdateUser({ user });
-    await updateUserData(result.user);
-    return result.user;
-  }, []);
+  const updateProfile = useCallback(
+    async (user: Partial<ApiUpdateUserRequest['user']>) => {
+      const result = await apiUpdateUser({ user });
+      await updateUserData(result.user);
+      return result.user;
+    },
+    [updateUserData]
+  );
 
   const updatePhoto = useCallback(
     async (file: File) => {
@@ -23,7 +26,7 @@ export const usePatchProfile = (updateUserData: (user: Partial<IUser>) => void)
         showErrorToast(error);
       }
     },
-    [updateUserData, uploadFile, updateProfile]
+    [uploadFile, updateProfile]
   );
 
   return { updatePhoto, updateProfile };
diff --git a/src/hooks/profile/useProfileForm.ts b/src/hooks/profile/useProfileForm.ts
new file mode 100644
index 00000000..768e47d9
--- /dev/null
+++ b/src/hooks/profile/useProfileForm.ts
@@ -0,0 +1,62 @@
+import { IUser } from '~/redux/auth/types';
+import { Asserts, object, string } from 'yup';
+import { ERRORS } from '~/constants/errors';
+import { FormikConfig, useFormik } from 'formik';
+import { useCallback, useRef } from 'react';
+import { showToastSuccess } from '~/utils/toast';
+import { getRandomPhrase } from '~/constants/phrases';
+import { showErrorToast } from '~/utils/errors/showToast';
+import { getValidationErrors } from '~/utils/errors/getValidationErrors';
+
+const validationSchema = object({
+  username: string()
+    .default('')
+    .required(ERRORS.REQUIRED),
+  fullname: string().default(''),
+  newPassword: string().optional(),
+  description: string().default(''),
+  email: string()
+    .default('')
+    .email(ERRORS.NOT_AN_EMAIL),
+  password: string().optional(),
+});
+
+export type ProfileFormData = Asserts<typeof validationSchema>;
+
+export const useProfileForm = (
+  values: ProfileFormData,
+  submitter: (data: ProfileFormData) => Promise<IUser>
+) => {
+  const initialValues = useRef(values).current;
+
+  const onSubmit = useCallback<FormikConfig<ProfileFormData>['onSubmit']>(
+    async (values, { setErrors, setValues }) => {
+      try {
+        const fields = {
+          ...values,
+          password: values.password?.length ? values.password : undefined,
+          new_password: values.newPassword?.length ? values.newPassword : undefined,
+        };
+
+        const result = await submitter(fields);
+
+        setValues({ ...result, password: '', newPassword: '' });
+        showToastSuccess(getRandomPhrase('SUCCESS'));
+      } catch (error) {
+        showErrorToast(error);
+
+        const validationErrors = getValidationErrors(error);
+        if (validationErrors) {
+          setErrors(validationErrors);
+        }
+      }
+    },
+    [submitter]
+  );
+
+  return useFormik({
+    initialValues,
+    onSubmit,
+    validationSchema,
+  });
+};
diff --git a/src/redux/auth/types.ts b/src/redux/auth/types.ts
index 761c1d60..652a4df5 100644
--- a/src/redux/auth/types.ts
+++ b/src/redux/auth/types.ts
@@ -91,7 +91,9 @@ export type ApiUserLoginResult = { token: string; user: IUser };
 export type ApiAuthGetUserRequest = {};
 export type ApiAuthGetUserResult = { user: IUser };
 
-export type ApiUpdateUserRequest = { user: Partial<IUser> };
+export type ApiUpdateUserRequest = {
+  user: Partial<IUser & { password: string; newPassword: string }>;
+};
 export type ApiUpdateUserResult = { user: IUser; errors: Record<Partial<keyof IUser>, string> };
 
 export type ApiAuthGetUserProfileRequest = { username: string };
diff --git a/src/utils/providers/ProfileProvider.tsx b/src/utils/providers/ProfileProvider.tsx
index 80364837..d072709a 100644
--- a/src/utils/providers/ProfileProvider.tsx
+++ b/src/utils/providers/ProfileProvider.tsx
@@ -1,5 +1,5 @@
 import { createContext, FC, useCallback, useContext } from "react";
-import { IUser } from "~/redux/auth/types";
+import { ApiUpdateUserRequest, IUser } from "~/redux/auth/types";
 import { useGetProfile } from "~/hooks/profile/useGetProfile";
 import { EMPTY_USER } from "~/redux/auth/constants";
 import { usePatchProfile } from "~/hooks/profile/usePatchProfile";
@@ -15,7 +15,7 @@ interface ProfileContextValue {
   profile: IUser;
   isLoading: boolean;
   updatePhoto: (file: File) => Promise<unknown>;
-  updateProfile: (user: Partial<IUser>) => Promise<IUser>;
+  updateProfile: (user: Partial<ApiUpdateUserRequest['user']>) => Promise<IUser>;
 }
 
 const ProfileContext = createContext<ProfileContextValue>({