From 140e36b6b7f3d29ff37121564f967f3d07d57d2a Mon Sep 17 00:00:00 2001
From: Fedor Katurov <gotham48@gmail.com>
Date: Wed, 5 Jan 2022 16:32:07 +0700
Subject: [PATCH] fixed ref forwarding on textareas

---
 src/components/comment/CommentForm/index.tsx  |  6 +--
 .../LocalCommentFormTextarea/index.tsx        | 17 ++++---
 src/components/input/Textarea/index.tsx       | 45 ++++++++++---------
 src/hooks/dom/useForwardRef.ts                | 17 +++++++
 src/hooks/dom/useInputPasteUpload.ts          | 17 ++-----
 5 files changed, 58 insertions(+), 44 deletions(-)
 create mode 100644 src/hooks/dom/useForwardRef.ts

diff --git a/src/components/comment/CommentForm/index.tsx b/src/components/comment/CommentForm/index.tsx
index a90375d9..d149d8f1 100644
--- a/src/components/comment/CommentForm/index.tsx
+++ b/src/components/comment/CommentForm/index.tsx
@@ -25,7 +25,7 @@ interface IProps {
 }
 
 const CommentForm: FC<IProps> = ({ comment, nodeId, saveComment, onCancelEdit }) => {
-  const [textarea, setTextarea] = useState<HTMLTextAreaElement>();
+  const [textarea, setTextArea] = useState<HTMLTextAreaElement | null>(null);
   const uploader = useFileUploader(
     UPLOAD_SUBJECTS.COMMENT,
     UPLOAD_TARGETS.COMMENTS,
@@ -55,7 +55,7 @@ const CommentForm: FC<IProps> = ({ comment, nodeId, saveComment, onCancelEdit })
   }, [formik]);
 
   const error = formik.status || formik.errors.text;
-  useInputPasteUpload(textarea, uploader.uploadFiles);
+  const onPaste = useInputPasteUpload(uploader.uploadFiles);
 
   return (
     <UploadDropzone onUpload={uploader.uploadFiles}>
@@ -63,7 +63,7 @@ const CommentForm: FC<IProps> = ({ comment, nodeId, saveComment, onCancelEdit })
         <FormikProvider value={formik}>
           <FileUploaderProvider value={uploader}>
             <div className={styles.input}>
-              <LocalCommentFormTextarea setRef={setTextarea} />
+              <LocalCommentFormTextarea onPaste={onPaste} ref={setTextArea} />
 
               {!!error && (
                 <div className={styles.error} onClick={clearError}>
diff --git a/src/components/comment/LocalCommentFormTextarea/index.tsx b/src/components/comment/LocalCommentFormTextarea/index.tsx
index 1dcc9640..f5e68d59 100644
--- a/src/components/comment/LocalCommentFormTextarea/index.tsx
+++ b/src/components/comment/LocalCommentFormTextarea/index.tsx
@@ -1,14 +1,18 @@
-import React, { FC, KeyboardEventHandler, useCallback } from 'react';
+import React, {
+  forwardRef,
+  KeyboardEventHandler,
+  TextareaHTMLAttributes,
+  useCallback,
+} from 'react';
 import { Textarea } from '~/components/input/Textarea';
 import { useCommentFormContext } from '~/hooks/comments/useCommentFormFormik';
 import { useRandomPhrase } from '~/constants/phrases';
 
-interface IProps {
+interface IProps extends TextareaHTMLAttributes<HTMLTextAreaElement> {
   isLoading?: boolean;
-  setRef?: (r: HTMLTextAreaElement) => void;
 }
 
-const LocalCommentFormTextarea: FC<IProps> = ({ setRef }) => {
+const LocalCommentFormTextarea = forwardRef<HTMLTextAreaElement, IProps>(({ ...rest }, ref) => {
   const { values, handleChange, handleSubmit, isSubmitting } = useCommentFormContext();
 
   const onKeyDown = useCallback<KeyboardEventHandler<HTMLTextAreaElement>>(
@@ -22,14 +26,15 @@ const LocalCommentFormTextarea: FC<IProps> = ({ setRef }) => {
 
   return (
     <Textarea
+      {...rest}
+      ref={ref}
       value={values.text}
       handler={handleChange('text')}
       onKeyDown={onKeyDown}
       disabled={isSubmitting}
       placeholder={placeholder}
-      ref={setRef}
     />
   );
-};
+});
 
 export { LocalCommentFormTextarea };
diff --git a/src/components/input/Textarea/index.tsx b/src/components/input/Textarea/index.tsx
index 0a6fa346..3cefba8a 100644
--- a/src/components/input/Textarea/index.tsx
+++ b/src/components/input/Textarea/index.tsx
@@ -1,11 +1,10 @@
 import React, {
   ChangeEvent,
   DetailedHTMLProps,
-  memo,
+  forwardRef,
   TextareaHTMLAttributes,
   useCallback,
   useEffect,
-  useRef,
   useState,
 } from 'react';
 import classNames from 'classnames';
@@ -13,6 +12,7 @@ import autosize from 'autosize';
 import styles from './styles.module.scss';
 
 import { InputWrapper } from '~/components/input/InputWrapper';
+import { useForwardRef } from '~/hooks/dom/useForwardRef';
 
 type IProps = DetailedHTMLProps<
   TextareaHTMLAttributes<HTMLTextAreaElement>,
@@ -27,20 +27,23 @@ type IProps = DetailedHTMLProps<
   title?: string;
 };
 
-const Textarea = memo<IProps>(
-  ({
-    placeholder,
-    error,
-    minRows = 3,
-    maxRows = 30,
-    className,
-    handler,
-    title = '',
-    value,
-    ...props
-  }) => {
+const Textarea = forwardRef<HTMLTextAreaElement, IProps>(
+  (
+    {
+      placeholder,
+      error,
+      minRows = 3,
+      maxRows = 30,
+      className,
+      handler,
+      title = '',
+      value,
+      ...props
+    },
+    forwardRef
+  ) => {
+    const ref = useForwardRef(forwardRef);
     const [focused, setFocused] = useState(false);
-    const ref = useRef<HTMLTextAreaElement>(null);
 
     const onInput = useCallback(
       ({ target }: ChangeEvent<HTMLTextAreaElement>) => handler(target.value),
@@ -52,20 +55,21 @@ const Textarea = memo<IProps>(
 
     useEffect(() => {
       if (!ref?.current) return;
-      autosize(ref.current);
-      return () => autosize.destroy(ref.current);
+      autosize(ref?.current);
+      return () => autosize.destroy(ref);
     }, [ref]);
 
     useEffect(() => {
-      if (!ref.current) return;
+      if (!ref?.current) return;
 
-      autosize.update(ref.current);
-    }, [value]);
+      autosize.update(ref);
+    }, [ref, value, forwardRef]);
 
     return (
       <InputWrapper title={title} error={error} focused={focused} notEmpty={!!value}>
         <textarea
           {...props}
+          ref={ref}
           style={{
             ...props.style,
             minHeight: minRows * 20,
@@ -74,7 +78,6 @@ const Textarea = memo<IProps>(
           placeholder={placeholder}
           className={classNames(styles.textarea, className)}
           onChange={onInput}
-          ref={ref}
           onFocus={onFocus}
           onBlur={onBlur}
         />
diff --git a/src/hooks/dom/useForwardRef.ts b/src/hooks/dom/useForwardRef.ts
new file mode 100644
index 00000000..2fc57dbd
--- /dev/null
+++ b/src/hooks/dom/useForwardRef.ts
@@ -0,0 +1,17 @@
+import { ForwardedRef, useEffect, useRef } from 'react';
+
+export const useForwardRef = <T>(ref: ForwardedRef<T | null>) => {
+  const targetRef = useRef<T | null>(null);
+
+  useEffect(() => {
+    if (!ref) return;
+
+    if (typeof ref === 'function') {
+      (ref as any)(targetRef.current);
+    } else {
+      (ref as any).current = targetRef.current;
+    }
+  }, [ref]);
+
+  return targetRef;
+};
diff --git a/src/hooks/dom/useInputPasteUpload.ts b/src/hooks/dom/useInputPasteUpload.ts
index ac206365..a0cf1fab 100644
--- a/src/hooks/dom/useInputPasteUpload.ts
+++ b/src/hooks/dom/useInputPasteUpload.ts
@@ -1,12 +1,9 @@
-import { useCallback, useEffect } from 'react';
+import { useCallback } from 'react';
 import { getImageFromPaste } from '~/utils/uploader';
 
 // useInputPasteUpload attaches event listener to input, that calls onUpload if user pasted any image
-export const useInputPasteUpload = (
-  input: HTMLTextAreaElement | HTMLInputElement | undefined,
-  onUpload: (files: File[]) => void
-) => {
-  const onPaste = useCallback(
+export const useInputPasteUpload = (onUpload: (files: File[]) => void) => {
+  return useCallback(
     async event => {
       const image = await getImageFromPaste(event);
 
@@ -16,12 +13,4 @@ export const useInputPasteUpload = (
     },
     [onUpload]
   );
-
-  useEffect(() => {
-    if (!input) return;
-
-    input.addEventListener('paste', onPaste);
-
-    return () => input.removeEventListener('paste', onPaste);
-  }, [input, onPaste]);
 };